Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit attachment order data from saves by default. #11771

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Omit attachment order data from saves by default. #11771

merged 3 commits into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. Omit attachment order data from saves by default. 

    This data is only needed for the "export to XML" function which is only used by mapmakers. However, the data is a huge contributor to save file size (and saving time). With this change, Imperialism 1974 saves go from 1.2MB in size to 800K (1/3 reduction).

The functionality to export to XML is maintained by re-reading the attachment order data from the original XML file when the export function is used.
    @asvitkine
    asvitkine committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ba7667d View commit details
    Browse the repository at this point in the history

  2. Remove import.

    @asvitkine
    asvitkine committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    452d31c View commit details
    Browse the repository at this point in the history

  3. Resolve TODO comment.

    @asvitkine
    asvitkine committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d07c75d View commit details
    Browse the repository at this point in the history