Revert "Disable pack200 compression in install4j. (#11765)" #11769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
This reverts commit 2523434.
Looks like despite the warnings, pack200 was still having a good impact on size.
If we compare:
https://github.com/triplea-game/triplea/releases/tag/2.6.14408
vs.:
https://github.com/triplea-game/triplea/releases/tag/2.6.14407
We can see that the installers went up in size (e.g. +22MB on Windows 64-bit). Only mac was not affected.
So this PR re-enables pack200.
Release Note