Install4J updates #11759
Merged
Install4J updates #11759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to Install4J 10.0.6 (latest version) from 9.0.6 - Update bundled JDK version to latest java 11 patch (11.0.19+7) - Switch Mac build to Universal (x86_64 + arm64) to support M1 macs The bump to latest JDK11 patchlevel should also pick up a fix for this UI issue on Mac: https://bugs.openjdk.org/browse/JDK-8251377
|
This failed the build. I'm going to look at what needs to be done to fix it. I see we're using some stuff from https://github.com/triplea-game/assets/tree/master/install4j |
|
Looks like it's not so easy. install4j_linux-x64_10_0_6.sh runs into GitHub's 100MB file size limit and GitHub then recommends using https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-git-large-file-storage for it instead, but I'm not sure how well that will work. Let me revert this for now and can try to reland in pieces - for example, I'm not sure if we really need install4j 10. |
asvitkine
added a commit
to asvitkine/triplea-1
that referenced
this pull request
Jul 10, 2023
This reverts commit b2a74c9.
asvitkine
added a commit
that referenced
this pull request
Jul 10, 2023
asvitkine
added a commit
to asvitkine/triplea-1
that referenced
this pull request
Jul 10, 2023
This reverts commit b2a74c9.
asvitkine
added a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
The bump to latest JDK11 patchlevel should also pick up a fix for this UI issue on Mac: https://bugs.openjdk.org/browse/JDK-8251377
Release Note