Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dropwizardVersion from 2.1.0 to 4.0.1 #11705

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 21, 2023

Bumps dropwizardVersion from 2.1.0 to 4.0.1.
Updates io.dropwizard:dropwizard-core from 2.1.0 to 4.0.1

Updates io.dropwizard:dropwizard-jdbi3 from 2.1.0 to 4.0.1

Updates io.dropwizard:dropwizard-testing from 2.1.0 to 4.0.1

Updates io.dropwizard:dropwizard-auth from 2.1.0 to 4.0.1

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 21, 2023
@DanVanAtta DanVanAtta closed this Jul 2, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 2, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/dropwizardVersion-4.0.1 branch July 2, 2023 04:57
@asvitkine
Copy link
Contributor

@dependabot reopen so I can see what the error is

@dependabot dependabot bot reopened this Aug 7, 2023
@dependabot dependabot bot restored the dependabot/gradle/dropwizardVersion-4.0.1 branch August 7, 2023 23:28
Bumps `dropwizardVersion` from 2.1.0 to 4.0.1.

Updates `io.dropwizard:dropwizard-core` from 2.1.0 to 4.0.1

Updates `io.dropwizard:dropwizard-jdbi3` from 2.1.0 to 4.0.1

Updates `io.dropwizard:dropwizard-testing` from 2.1.0 to 4.0.1

Updates `io.dropwizard:dropwizard-auth` from 2.1.0 to 4.0.1

---
updated-dependencies:
- dependency-name: io.dropwizard:dropwizard-core
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: io.dropwizard:dropwizard-jdbi3
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: io.dropwizard:dropwizard-testing
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: io.dropwizard:dropwizard-auth
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/dropwizardVersion-4.0.1 branch from e683346 to 44c2dd4 Compare August 7, 2023 23:28
@asvitkine
Copy link
Contributor

compile errors:

> Task :http-clients:github-client:jar
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/AuthenticationConfiguration.java:11: error: package io.dropwizard.setup does not exist

import io.dropwizard.setup.Environment;
> Task :servers:server-lib:compileJava FAILED
264 actionable tasks: 256 executed, 4 from cache, 4 up-to-date
                          ^
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/AuthenticationConfiguration.java:25: error: cannot find symbol
      final Environment environment,
            ^
  symbol:   class Environment
  location: class AuthenticationConfiguration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:3: error: cannot find symbol
import io.dropwizard.Configuration;
                    ^
  symbol:   class Configuration
  location: package io.dropwizard
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:7: error: package io.dropwizard.setup does not exist
import io.dropwizard.setup.Bootstrap;
                          ^
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:13: error: package javax.ws.rs.container does not exist
import javax.ws.rs.container.ContainerRequestFilter;
                            ^
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:21: error: cannot find symbol
public class ServerConfiguration<T extends Configuration> {
                                           ^
  symbol: class Configuration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:23: error: cannot find symbol
  private final Bootstrap<T> bootstrap;
                ^
  symbol:   class Bootstrap
  location: class ServerConfiguration<T>
  where T is a type-variable:
    T declared in class ServerConfiguration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:32: error: cannot find symbol
      final Bootstrap<T> bootstrap, final WebsocketConfig... websocketConfigs) {
            ^
  symbol:   class Bootstrap
  location: class ServerConfiguration<T>
  where T is a type-variable:
    T declared in class ServerConfiguration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:49: error: cannot find symbol
  public static <T extends Configuration> ServerConfiguration<T> build(
                           ^
  symbol:   class Configuration
  location: class ServerConfiguration<T>
  where T is a type-variable:
    T declared in class ServerConfiguration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:50: error: cannot find symbol
      final Bootstrap<T> bootstrap, final WebsocketConfig... websocketConfigs) {
            ^
  symbol:   class Bootstrap
  location: class ServerConfiguration<T>
  where T is a type-variable:
    T declared in class ServerConfiguration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:77: error: cannot find symbol
      final Environment environment, final ContainerRequestFilter containerRequestFilter) {
            ^
  symbol:   class Environment
  location: class ServerConfiguration<T>
  where T is a type-variable:
    T declared in class ServerConfiguration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:77: error: cannot find symbol
      final Environment environment, final ContainerRequestFilter containerRequestFilter) {
                                           ^
  symbol:   class ContainerRequestFilter
  location: class ServerConfiguration<T>
  where T is a type-variable:
    T declared in class ServerConfiguration
/home/runner/work/triplea/triplea/servers/server-lib/src/main/java/org/triplea/dropwizard/common/ServerConfiguration.java:90: error: cannot find symbol
      final Environment environment, final List<Object> exceptionMappers) {
            ^
  symbol:   class Environment
  location: class ServerConfiguration<T>
  where T is a type-variable:
    T declared in class ServerConfiguration
13 errors
```

I think classes were moved to different packages in new dropwizard version.

@asvitkine asvitkine closed this Aug 9, 2023
@dependabot dependabot bot deleted the dependabot/gradle/dropwizardVersion-4.0.1 branch August 9, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants