Improve message box text when not able to place sea units.

triplea-game · Jul 25, 2023 · 61b0fd2 · 61b0fd2
1 parent 603b889
commit 61b0fd2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/game-app/game-core/src/main/java/games/strategy/triplea/delegate/AbstractPlaceDelegate.java b/game-app/game-core/src/main/java/games/strategy/triplea/delegate/AbstractPlaceDelegate.java
@@ -612,18 +612,14 @@ protected String canProduce(
       if (errorP != null) {
         failingProducers.add(producer);
         // do not include the error for same territory, if water, because users do not want to see
-        // this error report for
-        // 99.9% of games
+        // this error report for 99.9% of games
         if (!(producer.equals(to) && producer.isWater())) {
-          error.append(", ").append(errorP);
+          error.append(errorP).append(".\n");
         }
       }
     }
     if (producers.size() == failingProducers.size()) {
-      return "Adjacent territories to "
-          + to.getName()
-          + " cannot produce, due to: \n "
-          + error.toString().replaceFirst(", ", "");
+      return String.format("Adjacent territories to %s cannot produce because:\n\n%s", to.getName(), error);
     }
     return null;
   }

diff --git a/game-app/game-headed/src/main/java/games/strategy/triplea/ui/PlacePanel.java b/game-app/game-headed/src/main/java/games/strategy/triplea/ui/PlacePanel.java
@@ -243,8 +243,8 @@ private PlaceableUnits getUnitsToPlace(final Territory territory) {
       if (production.isError()) {
         JOptionPane.showMessageDialog(
             getTopLevelAncestor(),
-            production.getErrorMessage(),
-            "No units",
+            production.getErrorMessage() + "\n\n",
+            "Cannot produce units",
             JOptionPane.INFORMATION_MESSAGE);
       }
       return production;