-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document join-pushdown.with-expressions
config property
#24145
base: master
Are you sure you want to change the base?
Document join-pushdown.with-expressions
config property
#24145
Conversation
- Enable [join pushdown](join-pushdown) with complex expressions. | ||
Equivalent [catalog session property](session-properties-definition) is | ||
`complex_join_pushdown_enabled`. | ||
- `true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mosabua follow-up
aggregation-pushdown.enabled
& topn-pushdown.enabled
(and their corresponding session properties) are nowhere to be found in the documentation (except in some old release notes). Please consider adding them in the existing documentation.
trino/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataConfig.java
Lines 92 to 107 in dd02ee9
@Config("aggregation-pushdown.enabled") | |
@LegacyConfig("allow-aggregation-pushdown") | |
@ConfigDescription("Enable aggregation pushdown") | |
public JdbcMetadataConfig setAggregationPushdownEnabled(boolean aggregationPushdownEnabled) | |
{ | |
this.aggregationPushdownEnabled = aggregationPushdownEnabled; | |
return this; | |
} | |
@Config("topn-pushdown.enabled") | |
@ConfigDescription("Enable TopN pushdown") | |
public JdbcMetadataConfig setTopNPushdownEnabled(boolean enabled) | |
{ | |
this.topNPushdownEnabled = enabled; | |
return this; | |
} |
trino/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java
Lines 64 to 68 in dd02ee9
.add(booleanProperty( | |
AGGREGATION_PUSHDOWN_ENABLED, | |
"Enable aggregation pushdown", | |
jdbcMetadataConfig.isAggregationPushdownEnabled(), | |
false)) |
trino/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java
Lines 81 to 85 in dd02ee9
.add(booleanProperty( | |
TOPN_PUSHDOWN_ENABLED, | |
"Enable TopN pushdown", | |
jdbcMetadataConfig.isTopNPushdownEnabled(), | |
false)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uff .. yeah .. we have to add them to a fragment that we include in all jdbc connectors .. maybe @jhlodin and team can help here
@@ -24,6 +24,11 @@ join pushdown: | |||
session property](session-properties-definition) is | |||
`join_pushdown_enabled`. | |||
- `true` | |||
* - `join-pushdown.with-expressions` | |||
- Enable [join pushdown](join-pushdown) with complex expressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have a bit more about what a "complex expression" is somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@findepi, @Praveen2112 can you please help out here with wording?
It is important for the users to knwo the distinction between join-pushdown.enabled
and join-pushdown.with-expressions
Description
Context
trino/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataConfig.java
Lines 79 to 80 in dd02ee9
trino/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java
Lines 59 to 63 in dd02ee9