Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document join-pushdown.with-expressions config property #24145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

findinpath
Copy link
Contributor

@findinpath findinpath commented Nov 16, 2024

Description

Context

@Config("join-pushdown.with-expressions")
@ConfigDescription("Enable join pushdown with complex expressions")

.add(booleanProperty(
COMPLEX_JOIN_PUSHDOWN_ENABLED,
"Enable join pushdown with non-comparison expressions",
jdbcMetadataConfig.isComplexJoinPushdownEnabled(),
false))

@cla-bot cla-bot bot added the cla-signed label Nov 16, 2024
@github-actions github-actions bot added the docs label Nov 16, 2024
- Enable [join pushdown](join-pushdown) with complex expressions.
Equivalent [catalog session property](session-properties-definition) is
`complex_join_pushdown_enabled`.
- `true`
Copy link
Contributor Author

@findinpath findinpath Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosabua follow-up

aggregation-pushdown.enabled & topn-pushdown.enabled (and their corresponding session properties) are nowhere to be found in the documentation (except in some old release notes). Please consider adding them in the existing documentation.

@Config("aggregation-pushdown.enabled")
@LegacyConfig("allow-aggregation-pushdown")
@ConfigDescription("Enable aggregation pushdown")
public JdbcMetadataConfig setAggregationPushdownEnabled(boolean aggregationPushdownEnabled)
{
this.aggregationPushdownEnabled = aggregationPushdownEnabled;
return this;
}
@Config("topn-pushdown.enabled")
@ConfigDescription("Enable TopN pushdown")
public JdbcMetadataConfig setTopNPushdownEnabled(boolean enabled)
{
this.topNPushdownEnabled = enabled;
return this;
}

.add(booleanProperty(
AGGREGATION_PUSHDOWN_ENABLED,
"Enable aggregation pushdown",
jdbcMetadataConfig.isAggregationPushdownEnabled(),
false))

.add(booleanProperty(
TOPN_PUSHDOWN_ENABLED,
"Enable TopN pushdown",
jdbcMetadataConfig.isTopNPushdownEnabled(),
false))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff .. yeah .. we have to add them to a fragment that we include in all jdbc connectors .. maybe @jhlodin and team can help here

@@ -24,6 +24,11 @@ join pushdown:
session property](session-properties-definition) is
`join_pushdown_enabled`.
- `true`
* - `join-pushdown.with-expressions`
- Enable [join pushdown](join-pushdown) with complex expressions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have a bit more about what a "complex expression" is somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@findepi, @Praveen2112 can you please help out here with wording?
It is important for the users to knwo the distinction between join-pushdown.enabled and join-pushdown.with-expressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants