feat: Tezos Provider #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianasavvatina
force-pushed
the
diana@tezos-provider
branch
from
dd31d5d
to
1b4c23a
Compare
dianasavvatina
force-pushed
the
diana@tezos-provider
branch
from
1b4c23a
to
e5cfdec
Compare
serjonya-trili
requested changes
Oct 24, 2024
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "tabWidth": 2, | |||
There was a problem hiding this comment.
it's more of an editorconfig thing
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "tabWidth": 2, | |||
| "useTabs": false, | |||
| "tabWidth": 2, | ||
| "useTabs": false, | ||
| "trailingComma": "all", | ||
| "printWidth": 100 |
| }, | ||
| files: ["**/*.ts"], | ||
| rules: { | ||
| "@typescript-eslint/ban-ts-ignore": ["off"], |
There was a problem hiding this comment.
are you confident of turning all of those off?
| ], | ||
| "scripts": { | ||
| "clean": "rm -rf dist", | ||
| "build": "tsup-node --dts", |
There was a problem hiding this comment.
you can puts the dts setting into the tsup config itself down below
| return await this.tezosSend(op); | ||
| }; | ||
|
|
||
| public tezosSendProposal = async (op: TezosProposalOperation): Promise<TezosSendResponse> => { |
There was a problem hiding this comment.
not sure if all those methods need the tezos prefix. it's obvious from the class name that it's tezos related
| return await this.tezosSend(op); | ||
| }; | ||
|
|
||
| public tezosSendIncreasePaidStorage = async ( |
There was a problem hiding this comment.
there is no need to await unless you want to catch errors or something. so it should be
public async sendIncreasePaidStorage(op: PartialTezosIncreasePaidStorageOperation) {
return this.tezosSend(op);
}| }, | ||
| "devDependencies": { | ||
| "@jest/globals": "^29.7.0", | ||
| "@swc/core": "^1.7.35", |
There was a problem hiding this comment.
so do you use swc or tsup in the end?
| "ignoreDeprecations": "5.0" | ||
|
|
||
| }, | ||
| "include": ["./src/**/*.ts", "./src"], |
There was a problem hiding this comment.
"include": ["src"]
| "include": ["./src/**/*.ts", "./src"], | ||
| "exclude": [ | ||
| "node_modules", | ||
| "test", |
There was a problem hiding this comment.
don't exclude test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Tezos Provider for WalletConnect SDK.
See README for usage examples.
Usage example: reown-com/web-examples#697
Testing:
Moved tezosProvider from WalletConnect Monorepo, PR#5357