Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search config file in XDG_CONFIG_HOME even on Windows #72

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Search config file in XDG_CONFIG_HOME even on Windows #72

merged 1 commit into from
Nov 19, 2023

Conversation

bew
Copy link
Contributor

@bew bew commented Nov 16, 2023

Also adds the Windows' standard directory in $APPDATA

NOTE: The code was not tested, and was made by looking at the code around and doing something similar.

Closes #71

NOTE: Also adds the Windows' standard directory in $APPDATA
@bew
Copy link
Contributor Author

bew commented Nov 16, 2023

I tested the binary from github action by replacing the installed binary by that one.

Works well for me 👍

@bovine3dom bovine3dom merged commit f9d19d1 into tridactyl:master Nov 19, 2023
3 checks passed
@bew bew deleted the patch-1 branch November 19, 2023 15:37
@bew
Copy link
Contributor Author

bew commented Nov 19, 2023

Cool thanks! 👌

So will new users / me in some time get this directly with normal install? or do you need to do a release?
(I basically want to know what to write in my own config README regarding this new behavior)

@bovine3dom
Copy link
Member

bovine3dom commented Nov 19, 2023

I need to do all the steps in #4 and then do a beta/stable release of Tridactyl

In theory the native messenger should get updated automatically but in practice it never happens, you'll need to rerun :nativeinstall

@bew
Copy link
Contributor Author

bew commented Nov 20, 2023

Thank you for the release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search config file under $XDG_CONFIG_HOME even on Windows
2 participants