Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): properly send the resume signal to homescreen layouts #4383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): properly send the resume signal to homescreen layouts #4383

wants to merge 1 commit into from
+17 −20

Conversation

matejcik
Copy link
Contributor

fixes flickering when account discovery is running

@matejcik matejcik self-assigned this Nov 25, 2024
@github-actions GitHub Actions
Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@github-actions GitHub Actions
Copy link

legacy UI changes device test(screens) main(screens)

@bosomt
Copy link

bosomt commented Nov 25, 2024

QA OK

no more flickering

Info:

  • Suite version: desktop 24.11.3 (112c22f9893956f2962972a3c2a7cf5e43a073e7)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.11.3 Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 771c9be)
  • Transport: BridgeTransport 2.0.33

mmilata
mmilata approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style check fails)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@obrusvit obrusvit Awaiting requested review from obrusvit

Assignees

@matejcik matejcik

Labels
None yet
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejcik @bosomt @mmilata