Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning_hi_prio and confirm_blob housekeeping. #4372

Open
wants to merge 2 commits into
base: ibz/20241113-tweaks
Choose a base branch
from
Open

warning_hi_prio and confirm_blob housekeeping. #4372

wants to merge 2 commits into from

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Nov 21, 2024 •
edited
Loading

Follow-up for #4346.

@ibz ibz self-assigned this Nov 21, 2024
@ibz
refactor(core/ui): introduce show_danger
945b901 
This is a unified interface for flow_warning_hi_prio,
which was available only on Mercury before.

[no changelog]
@ibz
refactor(core): remove confirm_blob unused params
d408154 
text_mono, info and hold were removed.

[no changelog]
@github-actions GitHub Actions
Copy link

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz linked an issue Nov 21, 2024 that may be closed by this pull request
Improve EVM contract flow #4302
Open
@ibz ibz marked this pull request as ready for review November 21, 2024 15:09
@ibz ibz requested a review from prusnak as a code owner November 21, 2024 15:09
@ibz ibz changed the title Ibz/20241121 tweaks warning_hi_prio and confirm_blob housekeeping. Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

@obrusvit obrusvit Awaiting requested review from obrusvit

@prusnak prusnak Awaiting requested review from prusnak prusnak is a code owner

Assignees

@ibz ibz

Labels
None yet
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve EVM contract flow
1 participant
@ibz