Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): unaligned array in protobuf decoder #4283

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Oct 24, 2024

Protobuf decoder is failing some newly added Rust assertions by creating unaligned slice: https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html#asserting-unsafe-preconditions

Draft: haven't tried this with 1.78+, there might be more such slices

@matejcik
Copy link
Contributor

won't this fail again if something pushes the whole enum entry block out of alignment?

@mmilata
Copy link
Member Author

mmilata commented Oct 29, 2024

yeah, it's an ad-hoc fix, i suppose that we should use something like construct.Aligned or construct.AlignedStruct on the python side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

2 participants