Resolve flaky test harness tests in command and integration suites #2482
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
+ Coverage 82.93% 90.76% +7.82%
==========================================
Files 299 299
Lines 57157 58877 +1720
==========================================
+ Hits 47404 53438 +6034
+ Misses 9753 5439 -4314
Flags with carried forward coverage won't be shown. Click here to find out more. see 97 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -345,6 +348,8 @@ pub(crate) fn process_filebased_asserts( | |||
| contains: None, | |||
| doesnt_contain: None, | |||
| equals_file: None, | |||
| is_empty: None, | |||
There was a problem hiding this comment.
is_empty and is_not_empty seem to be the same just inverted. It looks like they can be reduced to a single flag, halfing the needed code and preventing possible confusion.
Licenser
force-pushed
the
fix-flaky-tremorcli-tests
branch
2 times, most recently
from
c1d7971 to
8fbf62d
Compare
Signed-off-by: Darach Ennis <[email protected]>
Licenser
force-pushed
the
fix-flaky-tremorcli-tests
branch
from
8fbf62d to
0688fe5
Compare
| contains: | ||
| - | | ||
| {"action":"index","correlation":"baz","index":"my_little_index","payload":{"action":null,"cause":"this one has a different type underneath the same key and thus will fail elastic","snot":"baz","tremor":12},"success":false} | ||
| - source: ok.log |
There was a problem hiding this comment.
shouldn't this be a single contains with multiple elements? (same for error.log)
Description
Small fixes to file based assertions ( adds is_empty, is_not_empty predicates ) and
fixes to
elastic-verify-gdto resolve assertion failures when running the test harnessin CI mode.
Checklist
No change to production / critical code.
Performance
No impact
Note
This is in part a hedge to remove any potential impact to flaky CI coverage runs. No freezes, hangs or
odd stalls when running locally as follows:
The mystery deepens!