Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chart.yaml #267

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Update Chart.yaml #267

merged 2 commits into from
Jun 26, 2024

Conversation

itaigilo
Copy link
Contributor

No description provided.

Copy link
Contributor

@yonipeleg33 yonipeleg33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, see comment

version: 1.3.0
appVersion: 1.26.1
version: 1.4.0
appVersion: 1.28.0
Copy link
Contributor

@yonipeleg33 yonipeleg33 Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you bump minor instead of patch?
Edit:
I meant for the version, not the appVersion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.
Done.

@itaigilo itaigilo merged commit 12201d4 into master Jun 26, 2024
3 checks passed
@itaigilo itaigilo deleted the update-versions-for-v1.28.0 branch June 26, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants