Skip to content

Commit

Permalink
CI: disable persist-credentials for actions/checkout
Browse files Browse the repository at this point in the history
It is a possible security issue.
We do not want to persist credentials in the repo and thus exposing those
to further steps.

References:

* actions/checkout#485 (comment)
* azat/chdig#67
  • Loading branch information
gergelytraveltime committed Oct 25, 2024
1 parent 4a90b3f commit 2efed4d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:

steps:
- uses: actions/checkout@v3
with:
persist-credentials: false

- name: Set up Ruby 2.7
uses: ruby/setup-ruby@v1
Expand All @@ -41,6 +43,8 @@ jobs:

steps:
- uses: actions/checkout@v3
with:
persist-credentials: false
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:

steps:
- uses: actions/checkout@v3
with:
persist-credentials: false

- name: Set up Ruby 2.7
uses: ruby/setup-ruby@v1
Expand Down

0 comments on commit 2efed4d

Please sign in to comment.