Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Erlang 19 by updating rebar.config #25

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Fix compilation on Erlang 19 by updating rebar.config #25

merged 1 commit into from
Jul 1, 2016

Conversation

TBK145
Copy link
Contributor

@TBK145 TBK145 commented Jun 28, 2016

The old exometer dependency had a lager dependency which did not compile on Erlang 19.

However, newer exometer versions do not have a lager dependency, so I had to add one manually, which fixed compilation on Erlang 19.

@TBK145 TBK145 changed the title Fix compilation on Erlang 19 by updating rebar.config [WIP] Fix compilation on Erlang 19 by updating rebar.config Jun 28, 2016
@TBK145
Copy link
Contributor Author

TBK145 commented Jun 28, 2016

It just occurred to me that this doesn't work. Apparently exometer (or hut for that matter) needs an extra flag to use lager. I'm trying to find out how that has to be done.

@TBK145 TBK145 changed the title [WIP] Fix compilation on Erlang 19 by updating rebar.config Fix compilation on Erlang 19 by updating rebar.config Jun 28, 2016
@TBK145
Copy link
Contributor Author

TBK145 commented Jun 28, 2016

It turns out I only had to add lager to the app.src

@surik
Copy link
Contributor

surik commented Jun 28, 2016

Hi @TBK145,
looks you use exometer_core revision with hut but there isn't capability to change the default log system without some hacks, see: Feuerlabs/exometer_core#57

@TBK145
Copy link
Contributor Author

TBK145 commented Jun 28, 2016

I saw that there is some trouble with loggers, but with this pull request exometer still uses lager right?

@surik
Copy link
Contributor

surik commented Jun 28, 2016

It uses hut and hut has a capability to change it via the compile flags (SASL error_logger used by default) but I don't see any ways to set these flags for exometer_core when I use it with other applications such as exometer_influxdb or so on.

I think you did some tests with the latest exometer_core and saw its log messages but probably they are just error_logger messages translated to lager, aren't they?

Please, correct me if I'm wrong.

@TBK145
Copy link
Contributor Author

TBK145 commented Jun 28, 2016

I'm not sure, but that might very well be possible.

@TBK145
Copy link
Contributor Author

TBK145 commented Jul 1, 2016

I currently have a workaround where I specify the newer lager dependency in my own project. Would it be a solution to add lager 3.2.1 as a dependency to this project and use the old exometer_core ref?

@surik
Copy link
Contributor

surik commented Jul 1, 2016

Lets try

@TBK145
Copy link
Contributor Author

TBK145 commented Jul 1, 2016

I updated the PR, now it uses the same exometer_core commit as before, but lager 3.2.1 has been added as a dependency, so it compiles on Erlang 19.

@surik
Copy link
Contributor

surik commented Jul 1, 2016

Good! Can you add some description about what you did it to overrided lager in rebar.config?

@surik
Copy link
Contributor

surik commented Jul 1, 2016

And activate Erlang 19 in .travis.yml if it possible ;)

The old exometer dependency had a lager dependency which did not compile on Erlang 19.
@TBK145
Copy link
Contributor Author

TBK145 commented Jul 1, 2016

I added a comment to rebar.config and added Erlang 19 to .travis.yml.

@surik surik merged commit ff3a866 into travelping:master Jul 1, 2016
@surik
Copy link
Contributor

surik commented Jul 1, 2016

Thank you!

@surik surik mentioned this pull request Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants