Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import django_bulk_update instead of bulk_update #6793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erosennin
Copy link

The module name of django-bulk-update has changed from bulk_update to django_bulk_update in version 2.0.0 (see changelog). Pootle still uses the old package name. This still works most of the time, because django_bulk_update-2.2.0-py2.py3-none-any.whl on PyPI includes the old bulk_update module for backward compatibility. However, the source tree of django-bulk-update does not contain the bulk_update module anymore, and Pootle currently won't work if django-bulk-update is installed from source. This PR fixes that.

@phlax
Copy link
Member

phlax commented Dec 11, 2017

@erosennin looks good - but im wondering if we need to bump requirements to ensure that pootle uses the newer version of bulk update

@erosennin
Copy link
Author

@phlax looks like we already have django-bulk-update==2.2.0 in requirements/base.txt, it is currently the latest version of django-bulk-update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants