-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file provider #937
Conversation
@ebuildy Can you detail the issue you are referring to about multiple TLSStore ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you might wanna add a test for values.yaml
defaults. The test should check that:
- no configMap is created
- no extra volume is mounted
- no CLI parameters nor annotations are added
@ebuildy Thanks for this. I just need more details on
And we should be good to go. Since the TLSStore is configurable either with |
Well I didnt manage to "scope" TLSStore object (or any other CRD like Middleware) to a specific Traefik. To me this is not possible to run multiple Traefik instances, since there is no "selector". To give you an example, I know prometheus ServiceMonitor have NamespaceSelector field: "Selector to select which namespaces the Endpoints objects are discovered from." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I get it, thanks.
Thanks for this PR, too, it looks good and tested.
Would you please follow the FHS and use a path like /etc/traefik/dynamic
instead of /opt/traefik/extra-conf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
As discussed at #936 , this PR add the option to configure a traefik file provider, as an extra configuration.
Motivation
More
make test
and all the tests passed