Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Traefik Proxy): add tracing.sampleRate #1268

Closed
wants to merge 0 commits into from

Conversation

slayne
Copy link
Contributor

@slayne slayne commented Dec 5, 2024

What does this PR do?

This PR adds the option to specify a tracing samplingRate in the chart values

Motivation

The tracing samplingRate was not exposed in the values, meaning that we have to specify it directly in CLI options if needed.
solves #1269

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.
It has been introduced in v3.0 so there's no need to add a version checker.
About implementation, the double layer with is kinda weird.
Wdyt of those two options:

  1. Lazy option
{{- with .Values.tracing.sampleRate }}
[...]
  1. Refactor option
{{- with .Values.tracing }}
[all options starting .Values.tracing]
{{- with .sampleRate }}
[...]

@mloiseleur mloiseleur changed the title Add tracing.sampleRate to helm chart values feat(Traefik Proxy): add tracing.sampleRate Dec 6, 2024
@slayne slayne closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants