Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Plugins): 📝 detail behavior and expected values on plugin storage #1248

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

darkweaver87
Copy link
Contributor

@darkweaver87 darkweaver87 commented Nov 4, 2024

What does this PR do?

Detail behavior and expected values on plugin storage

Motivation

Current example is inaccurate with current chart version.

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur mloiseleur changed the title fix: 📝 fix plugin documentation to git chart current behavior docs(Plugins): 📝 detail behavior and expected values on plugin storage Nov 6, 2024
@mloiseleur mloiseleur added area/documentation Improvements or additions to documentation and removed kind/bug/fix labels Nov 6, 2024
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkweaver87 You'll find my review in bee2cc9.

@traefiker traefiker merged commit 9a5b396 into traefik:master Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants