Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 🚀 publish v33.0.0 #1240

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

mloiseleur
Copy link
Contributor

What does this PR do?

Publish a new release.

Motivation

This release default on last stable version: v3.2.0

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sheddy-traefik sheddy-traefik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me but I made some grammartical changes :)

traefik/Changelog.md Outdated Show resolved Hide resolved
traefik/Changelog.md Outdated Show resolved Hide resolved
traefik/Changelog.md Outdated Show resolved Hide resolved
traefik/Changelog.md Outdated Show resolved Hide resolved
traefik/Changelog.md Outdated Show resolved Hide resolved
traefik/Changelog.md Outdated Show resolved Hide resolved
+certificatesResolvers: {}

# -- If hostNetwork is true, runs traefik in the host network namespace
# To prevent unschedulabel pods due to port collisions, if hostNetwork=true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# To prevent unschedulabel pods due to port collisions, if hostNetwork=true
# To prevent unschedulable pods due to port collisions, if hostNetwork=true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! This one has to be done on values.yaml, not this PR. It will be for the next release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened this PR to fix it: #1241

Copy link

@sheddy-traefik sheddy-traefik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 045b735 into traefik:master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants