Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: いらなくなったイベントを削除するように #983

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

mathsuky
Copy link
Contributor

@mathsuky mathsuky commented Oct 28, 2024

traPtitech/knoQ#570
を解決する過程で,今のままだと過去の月で取得した複数日開催のイベントが配列に残ってしまっていて見栄えが悪いことに気がついたので,毎回配列をからにするようにしました。

@mathsuky mathsuky requested a review from itt828 October 28, 2024 15:10
@mathsuky
Copy link
Contributor Author

すみません,一個上のコミットがないと月末のイベントが落ちるのを忘れていました:pray:

Copy link
Member

@itt828 itt828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
1点だけ、startDateの方もひとつき前まで取得するようにお願いします:pray:

@mathsuky
Copy link
Contributor Author

レビューありがとうございます!修正しましたので,再レビューお願いします:pray:

@mathsuky mathsuky requested a review from itt828 November 11, 2024 12:41
Copy link
Member

@itt828 itt828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ありがとうございました!

@mathsuky mathsuky merged commit 391cac6 into master Nov 11, 2024
8 checks passed
@mathsuky mathsuky deleted the fix/calendar-rendering branch November 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants