Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now replacing comments with harmless dummy comments before processing… #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smarie
Copy link

@smarie smarie commented Jul 24, 2019

… so as to fix bug when they contain reserved expressions. Fixes #8

… so as to fix bug when they contain reserved expressions. Fixes tqdm#8
@coveralls
Copy link

coveralls commented Jul 24, 2019

Coverage Status

Coverage increased (+0.06%) to 96.667% when pulling 3fd465b on smarie:fix_issue_8 into 66c71a7 on tqdm:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 96.667% when pulling 87b3975 on smarie:fix_issue_8 into 66c71a7 on tqdm:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 96.667% when pulling 87b3975 on smarie:fix_issue_8 into 66c71a7 on tqdm:master.

@casperdcl casperdcl self-assigned this Aug 1, 2019
@casperdcl
Copy link
Member

the problem with this is:

test:
        echo 'hash#es'

@codecov-io
Copy link

Codecov Report

Merging #9 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   94.06%   94.16%   +0.09%     
==========================================
  Files           6        6              
  Lines         118      120       +2     
  Branches       25       26       +1     
==========================================
+ Hits          111      113       +2     
  Misses          4        4              
  Partials        3        3

@smarie
Copy link
Author

smarie commented Aug 31, 2019

I see. That might be a little trickier to do then, as of now I have no elegant suggestion to cover this case, apart from explicitly taking into account each possible quote character ' and " (simply finding the beginning-end indices of pairs)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PymakeKeyError: 'No substitution for macros...'when the macros are in commented lines
4 participants