Week 6 #23
Week 6 #23
Conversation
the commit.
Added the documentation for /delete route
Added Day 12 Material
Added Week 7 Items
|
|
||
| // console.log(window.localStorage.getItem("username")) | ||
|
|
||
| }); |
There was a problem hiding this comment.
When you use useEffect, please note the dependency lists you are using. You call this API multiple times unintentionally because you don't use a dependency list in React.
| uid: doc.id | ||
| }); | ||
|
|
||
| res.status(200).send("OK") |
There was a problem hiding this comment.
You are currently returning text; shouldn't you return the JSON from doc2? As a result, you are getting a
SyntaxError: Unexpected token 'O', "OK" is not valid JSON on the frontend side when you try to convert this text to a json to console log.
| //const todos = await todo.where('email', '==', body.email).get(); | ||
| const ret = todos.docs.map((obj) => obj.data()); | ||
|
|
||
| // (todos.docs).forEach(doc => console.log(doc.id)) |
There was a problem hiding this comment.
Nit: when you write code that will be reviewed, I'd remove commented out code unless its really necessary for the review / future code changes.
| const express = require("express"); | ||
| const cors = require("cors"); | ||
| const app = express() |
There was a problem hiding this comment.
You never use this import, please remove
|
|
||
|
|
||
|
|
||
| //get |
There was a problem hiding this comment.
Remove all these comments if not in use
| const express = require("express"); | ||
| const cors = require("cors"); | ||
| const app = express() | ||
| const cors = require('cors') |
There was a problem hiding this comment.
You should be able to not have to call cors in the todo.js and instead call it for index.js which will automatically apply cors to all your routes. Test this though and let me know if it works
| email: body.email, | ||
| }); | ||
|
|
||
| const doc2 = await db.collection('todos').doc(doc.id).update({ |
There was a problem hiding this comment.
Alternatively, you don't have to make two calls to the database to augment the todo (since you're duplicating the data).
Just save doc and in the /GET route, augment the data with the uid then:
todos.docs.map(obj => {const data = {...obj.data(), uid: obj.id}; return data})
No description provided.