Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext] fix: translate the buttons rate now, rate later and watch #1997

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

GresilleSiffle
Copy link
Collaborator

@GresilleSiffle GresilleSiffle commented Jul 23, 2024

related issues #1917


Description

The buttons Rate Now, Rate Later and Watch on Tournesol displayed on the YT video pages are now translated in French (in addition to English).

capture

Checklist

  • I added the related issue(s) id in the related issues section (if any)
    • if not, delete the related issues section
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

@GresilleSiffle GresilleSiffle self-assigned this Jul 23, 2024
@GresilleSiffle GresilleSiffle marked this pull request as ready for review July 23, 2024 13:57
@GresilleSiffle GresilleSiffle added Extension Development of the browser extension Bug Something isn't working labels Jul 23, 2024
@GresilleSiffle GresilleSiffle merged commit b34e8f9 into main Jul 30, 2024
6 checks passed
@GresilleSiffle GresilleSiffle deleted the 1917-translate_video_buttons branch July 30, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Extension Development of the browser extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants