Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext] bug: translation of the action buttons under YouTube videos not set up #1917

Closed
maximedrouhin opened this issue Feb 10, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working Extension Development of the browser extension

Comments

@maximedrouhin
Copy link
Contributor

The following buttons are not only not translated to French, but it also seems like translation for the relevant strings is not set up (see CONTRIBUTING.md#translation).

image

Here's the Discord conversation from which this stems:
https://discord.com/channels/760540475139817472/760540475668824118/1206003608240529418.

Warning: At the time of writing, there's a pending PR (#1916) that changes addVideoButtons.js, which is where the buttons are named with hard-coded strings. It might be best to accept it before taking care of this issue.

@GresilleSiffle GresilleSiffle added Extension Development of the browser extension Bug Something isn't working labels Feb 12, 2024
@GresilleSiffle GresilleSiffle self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Extension Development of the browser extension
Projects
Status: Done
Development

No branches or pull requests

2 participants