Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a bit of thinking, I've determined a way to implement async support in the most minimal way possible.
By creating an
AsyncRequestHandler
and having variants of the *arrs (ex.AsyncSonarrAPI
) use this subclass, this allows for the existing code to return async.As a result, sonarr/radarr/readarr/etc models will not need to be modified to maintain async support.
Task List
typing.cast
andinspect.getfullargspec
?ReturnType
that all methods use? Not sure whether python type hinting is flexible enough to handle this though.Related issues
Type of change
How has this been tested
nox -s tests
locally and passed