Proxy context authorization tests #764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-nt
force-pushed
the
615-proxy-context-authorization-tests
branch
from
f5014c1 to
e94e9cd
Compare
josecelano
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Hi @mario-nt, what is the state of this PR? I think the test is flaky (external dependencies) because the image could not be available. If we want to add it, we should start a server at localhost (free port) to serve a fixture image. But since the proxy is public we can ignore it for now, unless it can be converted to private via casbin configuration (unstable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #615