-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-6047] Fix UserBadge padding in PageTopBarMenu #4589
Conversation
🦋 Changeset detectedLatest commit: d3d2ee9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1f677eb
to
d627ae4
Compare
@toptal-anvil ping reviewers |
1 similar comment
@toptal-anvil ping reviewers |
5933f32
to
f6cd05f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on temploy, visual test additions looks good too!
@toptal-anvil ping reviewers |
FX-6047
Description
Describe the changes and motivations for the pull request.
How to test
PageTopBar
stories page.Page.TopBar.Menu
stories.<1000px
and click on avatar in the right corner ofPageTopBar
.Screenshots
Development checks
picasso-tailwind-merge
requires major update (check itsREADME.md
)Read CONTRIBUTING.md and Component API principlesMake sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-coreAnnotate allprops
in component with documentationCreateexamples
for componentEnsure that deployed demo has expected results and good examplesEnsure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.Breaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?