[FX-5687] Migrate PageFooter to TailwindCSS #4584
Open
+47
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9d5535 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ruslan-sed
force-pushed
the
fx-5687-migrate-pagefooter
branch
4 times, most recently
from
27e3c0e
to
dcd19f8
Compare
|
@toptal-anvil ping reviewers |
TomasSlama
approved these changes
Sep 30, 2024
ruslan-sed
commented
Oct 1, 2024
ruslan-sed
force-pushed
the
fx-5687-migrate-pagefooter
branch
from
2b891df
to
0c0b96d
Compare
ruslan-sed
force-pushed
the
fx-5687-migrate-pagefooter
branch
from
0c0b96d
to
c9d5535
Compare
|
@toptal-anvil ping reviewers |
ruslan-sed
commented
Oct 2, 2024
| @@ -2,9 +2,9 @@ import React from 'react' | |||
| import { Page, Typography } from '@toptal/picasso' | |||
|
|
|||
| const Example = () => ( | |||
| <div> | |||
| <Page> | |||
There was a problem hiding this comment.
I added Page here and in two other stories because without it CSS variables are missed and storybook visual tests fail.
|
@toptal-anvil ping reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-5687
How to test
Development checks
picasso-tailwind-mergerequires major update (check itsREADME.md)Read CONTRIBUTING.md and Component API principlesMake sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-coreAnnotate allpropsin component with documentationCreateexamplesfor componentEnsure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.Covered with tests (visual tests included)Breaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release- Release alpha version@toptal-anvil ping reviewers- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?