Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FX-5973] Update tag to span #4567

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[FX-5973] Update tag to span #4567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/eighty-eagles-warn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@toptal/picasso-tag': patch
'@toptal/picasso': patch
---

- update HTML tag of Tag.Rectangular to span
1 change: 1 addition & 0 deletions packages/base/Tag/src/TagRectangular/TagRectangular.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const TagRectangular = forwardRef<HTMLDivElement, Props>(
variant === 'light-grey' ? 'text-graphite-800' : 'text-white'
)}
titleCase={titleCase}
as='span'
>
{children}
</Typography>
Expand Down
4 changes: 2 additions & 2 deletions packages/base/Tag/src/TagRectangular/__snapshots__/test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ exports[`TagRectangular renders rectangular Tag 1`] = `
<div
class="text-lg transition-none rounded-sm font-semibold h-4 inline-flex content-center justify-center align-middle bg-gray"
>
<p
<span
class="m-0 text-2xs font-semibold whitespace-nowrap overflow-ellipsis overflow-hidden mx-1 w-max text-graphite"
>
Reactangular Tag
</p>
</span>
</div>
</div>
</div>
Expand Down
Loading