-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4719] Remove error prop on Form fields #4531
[FX-4719] Remove error prop on Form fields #4531
Conversation
🦋 Changeset detectedLatest commit: 7e1ad76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small NIT on the changeset file, but otherwise everything looks great! GJ! 👍
FX-4719
Description
This PR removes the
error
prop and replaces it with thestatus
prop which has two statessuccess
anderror
for the following components: Autocomplete, DatePicker, Input, NumberInput, OutlinedInput, PasswordInput, Select, TagSelector, TimePicker, RichTextEditor.How to test
error
prop has been removed from the Props section of the Storybook and that the stories are working properly.Screenshots
Development checks
picasso-tailwind-merge
requires major update (check itsREADME.md
)Read CONTRIBUTING.md and Component API principlesAnnotate allprops
in component with documentationCreateexamples
for componentEnsure that deployed demo has expected results and good examplesEnsure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.Covered with tests (visual tests included)Breaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?