Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5856] Delete Maybe export from picasso/utils package #4527

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

AdrianContiu
Copy link
Contributor

@AdrianContiu AdrianContiu commented Sep 5, 2024

FX-5856

Description

Since the Maybe type along with other GQL types has been extracted into a separate package in Topkit, it should not be exported further from picasso/utils. Because Maybe is not used anywhere inside Picasso, this PR only removes the export.

How to test

  • Temploy
  • check that there are no references to Maybe type in Picasso.

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@AdrianContiu AdrianContiu self-assigned this Sep 5, 2024
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: ff1e215

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 80 packages
Name Type
@toptal/picasso-utils Major
@toptal/picasso Major
@toptal/picasso-charts Patch
@toptal/picasso-forms Patch
@toptal/picasso-pictograms Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso-tailwind-merge Patch
@topkit/analytics-charts Patch
@toptal/picasso-accordion Patch
@toptal/picasso-account-select Patch
@toptal/picasso-alert Patch
@toptal/picasso-amount Patch
@toptal/picasso-application-update-notification Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-avatar Patch
@toptal/picasso-avatar-upload Patch
@toptal/picasso-backdrop Patch
@toptal/picasso-badge Patch
@toptal/picasso-breadcrumbs Patch
@toptal/picasso-button Patch
@toptal/picasso-calendar Patch
@toptal/picasso-carousel Patch
@toptal/picasso-checkbox Patch
@toptal/picasso-collapse Patch
@toptal/picasso-container Patch
@toptal/picasso-date-picker Patch
@toptal/picasso-date-select Patch
@toptal/picasso-drawer Patch
@toptal/picasso-dropdown Patch
@toptal/picasso-dropzone Patch
@toptal/picasso-fade Patch
@toptal/picasso-file-input Patch
@toptal/picasso-form Patch
@toptal/picasso-grid Patch
@toptal/picasso-helpbox Patch
@toptal/picasso-icons Patch
@toptal/picasso-image Patch
@toptal/picasso-input Patch
@toptal/picasso-input-adornment Patch
@toptal/picasso-link Patch
@toptal/picasso-list Patch
@toptal/picasso-loader Patch
@toptal/picasso-logo Patch
@toptal/picasso-menu Patch
@toptal/picasso-modal Patch
@toptal/picasso-notification Patch
@toptal/picasso-number-input Patch
@toptal/picasso-outlined-input Patch
@toptal/picasso-overview-block Patch
@toptal/picasso-page Patch
@toptal/picasso-pagination Patch
@toptal/picasso-paper Patch
@toptal/picasso-password-input Patch
@toptal/picasso-popper Patch
@toptal/picasso-prompt-modal Patch
@toptal/picasso-radio Patch
@toptal/picasso-rating Patch
@toptal/picasso-section Patch
@toptal/picasso-select Patch
@toptal/picasso-skeleton-loader Patch
@toptal/picasso-slide Patch
@toptal/picasso-slider Patch
@toptal/picasso-step Patch
@toptal/picasso-table Patch
@toptal/picasso-tabs Patch
@toptal/picasso-tag Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-timeline Patch
@toptal/picasso-timepicker Patch
@toptal/picasso-tooltip Patch
@toptal/picasso-tree-view Patch
@toptal/picasso-typography Patch
@toptal/picasso-typography-overflow Patch
@toptal/picasso-user-badge Patch
@toptal/picasso-note Patch
@toptal/picasso-show-more Patch
@toptal/picasso-empty-state Patch
@toptal/picasso-quote Patch
@toptal/picasso-switch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianContiu AdrianContiu marked this pull request as ready for review September 5, 2024 11:56
@AdrianContiu AdrianContiu requested a review from a team as a code owner September 5, 2024 11:56
@sashuk sashuk requested a review from a team September 5, 2024 12:03
@sashuk
Copy link
Contributor

sashuk commented Sep 5, 2024

@toptal-anvil ping reviewers

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sashuk sashuk requested a review from a team September 5, 2024 14:52
@AdrianContiu AdrianContiu merged commit 80407eb into master Sep 6, 2024
18 checks passed
@AdrianContiu AdrianContiu deleted the fx-5856-delete-maybe-export-from-picasso-utils branch September 6, 2024 12:12
@toptal-build toptal-build mentioned this pull request Sep 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants