-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-5856] Delete Maybe export from picasso/utils package #4527
Merged
AdrianContiu
merged 4 commits into
master
from
fx-5856-delete-maybe-export-from-picasso-utils
Sep 6, 2024
Merged
[FX-5856] Delete Maybe export from picasso/utils package #4527
AdrianContiu
merged 4 commits into
master
from
fx-5856-delete-maybe-export-from-picasso-utils
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff1e215 The changes in this PR will be included in the next version bump. This PR includes changesets to release 80 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AdrianContiu
commented
Sep 5, 2024
sashuk
reviewed
Sep 5, 2024
@toptal-anvil ping reviewers |
sashuk
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
dmaklygin
approved these changes
Sep 6, 2024
AdrianContiu
deleted the
fx-5856-delete-maybe-export-from-picasso-utils
branch
September 6, 2024 12:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-5856
Description
Since the
Maybe
type along with other GQL types has been extracted into a separate package in Topkit, it should not be exported further frompicasso/utils
. Because Maybe is not used anywhere inside Picasso, this PR only removes the export.How to test
Development checks
picasso-tailwind-merge
requires major update (check itsREADME.md
)Read CONTRIBUTING.md and Component API principlesMake sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-coreAnnotate allprops
in component with documentationCreateexamples
for componentEnsure that deployed demo has expected results and good examplesEnsure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.Covered with tests (visual tests included)Breaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?