Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[CPT-2535] Add property to place accordion icon on the left" #4526

Conversation

angelinastavniiciuc
Copy link
Contributor

Reverts #4522

@angelinastavniiciuc angelinastavniiciuc self-assigned this Sep 5, 2024
@angelinastavniiciuc angelinastavniiciuc requested a review from a team as a code owner September 5, 2024 09:44
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: 4150c3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@toptal/picasso-rich-text-editor Major
@toptal/picasso-typography-overflow Major
@toptal/picasso-pictograms Major
@toptal/picasso-accordion Major
@toptal/picasso-file-input Major
@toptal/picasso-dropzone Major
@toptal/picasso-timeline Major
@toptal/picasso-forms Major
@toptal/picasso-page Major
@toptal/picasso-step Major
@toptal/picasso-tabs Major
@toptal/picasso Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot added the contribution DO NOT ADD MANUALLY label Sep 5, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @angelinastavniiciuc 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@sashuk
Copy link
Contributor

sashuk commented Sep 5, 2024

@angelinastavniiciuc Can you please add changeset?

@angelinastavniiciuc
Copy link
Contributor Author

Member

@sashuk yup, on it, just not sure which bump should it be major or minor ? and whether I should include all changed packages or only accordion ?

@sashuk
Copy link
Contributor

sashuk commented Sep 5, 2024

@angelinastavniiciuc

which bump should it be major or minor ?

This should be a major one, as new public API of Accordion is going to be incompatible with the old one

include all changed packages or only accordion ?

Let's include all packages that changeset will mark as "updated"

@angelinastavniiciuc
Copy link
Contributor Author

@sashuk can you please help with failing Happo check ? (it is because the added visual test was removed now)

@sashuk
Copy link
Contributor

sashuk commented Sep 5, 2024

@angelinastavniiciuc Done!

@angelinastavniiciuc angelinastavniiciuc merged commit 310302a into master Sep 5, 2024
18 checks passed
@angelinastavniiciuc angelinastavniiciuc deleted the revert-4522-CPT-2535-add-property-to-place-picasso-accordion-icon-on-the-left branch September 5, 2024 10:32
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants