-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package generator #4473
base: master
Are you sure you want to change the base?
Add package generator #4473
Conversation
|
to: <%= packagePath %>/tsconfig.json | ||
sh: "yarn install && lerna run --scope=<%= packageName %> build:package" | ||
--- | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do the following?
{ | |
<% | |
function resolvePath(base, relative) { | |
return isBasePackage ? base : relative; | |
} | |
const references = [ | |
{ "path": resolvePath('../../picasso-provider', '../picasso-provider') }, | |
{ "path": resolvePath('../../picasso-tailwind', '../picasso-tailwind') }, | |
{ "path": resolvePath('../../picasso-tailwind-merge', '../picasso-tailwind-merge') }, | |
{ "path": resolvePath('../Utils', '../base/Utils') } | |
]; | |
%> | |
{ | |
// Extend the base tsconfig | |
"extends": "<%= resolvePath('../../../tsconfig.base.json', '../../tsconfig.base.json') %>", | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, in theory you should be able to run any JS in ejs templates, but I've not tried it. Not sure if it will work, I'll give it a try tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, works well
[FX-NNNN]
Description
Updates outdated tutorials on package generation and adds a new Hygen generator to insert packages.
How to test
yarn generate:package
and follow the instructions:packages/base
packages
Development checks
props
in component with documentationexamples
for componentPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?