Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-NULL] Revert debounce update #4090

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Jan 11, 2024

FX-4727

Description

This pull request reverts [email protected] update (#4079), as it causes Staff Portal Cypress tests to fail with the following error

@staff-portal/clients-profile-app:   2) Enable Embedded Contract Signing
@staff-portal/clients-profile-app:        when the mutation is not successful
@staff-portal/clients-profile-app:          does not enable embedded contract signing and displays a form error:
@staff-portal/clients-profile-app:      Error: The following error originated from your application code, not from Cypress.
@staff-portal/clients-profile-app:   > Debounced method called with different contexts.
@staff-portal/clients-profile-app: When Cypress detects uncaught errors originating from your application it will automatically fail the current test.
@staff-portal/clients-profile-app: This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.
@staff-portal/clients-profile-app: https://on.cypress.io/uncaught-exception-from-application
@staff-portal/clients-profile-app:       at MutationObserver.debounced (http://localhost:8080/__cypress/src/main.js:726794:19)
@staff-portal/clients-profile-app: 
@staff-portal/clients-profile-app:   (Results)
@staff-portal/clients-profile-app:   ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
@staff-portal/clients-profile-app:   │ Tests:        2                                                                                │
@staff-portal/clients-profile-app:   │ Passing:      0                                                                                │
@staff-portal/clients-profile-app:   │ Failing:      2                                                                                │
@staff-portal/clients-profile-app:   │ Pending:      0                                                                                │
@staff-portal/clients-profile-app:   │ Skipped:      0                                                                                │
@staff-portal/clients-profile-app:   │ Screenshots:  0                                                                                │
@staff-portal/clients-profile-app:   │ Video:        false                                                                            │
@staff-portal/clients-profile-app:   │ Duration:     31 seconds                                                                       │
@staff-portal/clients-profile-app:   │ Spec Ran:     profile-page/pages/ClientProfile/__tests__/profile-actions/enable-embedded-contr │
@staff-portal/clients-profile-app:   │               act-signing.cy.ts                                                                │
@staff-portal/clients-profile-app:   └────────────────────────────────────────────────────────────────────────────────────────────────┘
@staff-portal/clients-profile-app: ────────────────────────────────────────────────────────────────────────────────────────────────────
@staff-portal/clients-profile-app:             

The error is caused from latest major version of debounce and by sindresorhus/debounce@95eef87#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R28 in particular.

How to test

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Jan 11, 2024
Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 238b622

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@toptal/picasso-charts Patch
@toptal/picasso-forms Patch
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal toptal deleted a comment from toptal-devbot Jan 11, 2024
@sashuk sashuk force-pushed the FX-NULL-revert-debounce-update branch from 5fc88f0 to 8138028 Compare January 12, 2024 10:11
@toptal toptal deleted a comment from toptal-devbot Jan 12, 2024
@sashuk sashuk force-pushed the FX-NULL-revert-debounce-update branch from 8138028 to a0a850e Compare January 12, 2024 11:12
@sashuk sashuk changed the title [FX-NULL] Revert debounce update [FX-NULL] Revert debounce update and remove injectFirst Jan 12, 2024
@toptal toptal deleted a comment from toptal-devbot Jan 12, 2024
@sashuk sashuk force-pushed the FX-NULL-revert-debounce-update branch from a0a850e to 97f0de8 Compare January 15, 2024 14:28
@toptal toptal deleted a comment from toptal-devbot Jan 15, 2024
@sashuk sashuk force-pushed the FX-NULL-revert-debounce-update branch from c39549e to d9920fa Compare January 15, 2024 18:38
@toptal toptal deleted a comment from toptal-devbot Jan 15, 2024
@sashuk sashuk changed the title [FX-NULL] Revert debounce update and remove injectFirst [FX-NULL] Revert debounce update Jan 15, 2024
@sashuk sashuk closed this Jan 17, 2024
@sashuk sashuk deleted the FX-NULL-revert-debounce-update branch January 17, 2024 09:35
@sashuk sashuk restored the FX-NULL-revert-debounce-update branch January 18, 2024 17:24
@sashuk sashuk reopened this Jan 18, 2024
@sashuk sashuk force-pushed the FX-NULL-revert-debounce-update branch from d9920fa to 238b622 Compare January 18, 2024 17:25
@sashuk sashuk marked this pull request as ready for review January 18, 2024 17:27
@sashuk sashuk requested a review from a team as a code owner January 18, 2024 17:27
@toptal toptal deleted a comment from toptal-devbot Jan 18, 2024
@sashuk sashuk enabled auto-merge (squash) January 18, 2024 17:37
@sashuk sashuk merged commit b024f26 into master Jan 18, 2024
20 of 28 checks passed
@sashuk sashuk deleted the FX-NULL-revert-debounce-update branch January 18, 2024 17:38
@toptal-build toptal-build mentioned this pull request Jan 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants