Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4483] Add Jira tickets for deprecated functionality #4077

Conversation

augustobmoura
Copy link
Member

@augustobmoura augustobmoura commented Jan 8, 2024

FX-4483

Description

Add Jira tickets for deprecated annotations

How to test

  • Temploy
  • No testing, just check if all docs are ok

Screenshots

No screenshots

Development checks

Breaking change

  • [NA] codemod is created and showcased in the changeset
  • [NA] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@augustobmoura augustobmoura self-assigned this Jan 8, 2024
@augustobmoura augustobmoura requested a review from a team as a code owner January 8, 2024 02:46
Copy link

changeset-bot bot commented Jan 8, 2024

⚠️ No Changeset found

Latest commit: 2a29d7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@augustobmoura augustobmoura force-pushed the fx-4483-review-and-create-follow-ups-for-deprecated-parts-of-picasso branch from 1e2a2b5 to f50a6f4 Compare January 8, 2024 02:51
@augustobmoura augustobmoura enabled auto-merge (squash) January 8, 2024 03:01
Copy link
Member

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's time we properly schedule and deal with those deprecations 💪

@augustobmoura augustobmoura enabled auto-merge (squash) January 9, 2024 03:16
@augustobmoura augustobmoura force-pushed the fx-4483-review-and-create-follow-ups-for-deprecated-parts-of-picasso branch from b49e5eb to 97fe08c Compare January 9, 2024 03:17
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thank you!

Created ticket are also very detailed and properly described. They miss labels with schedule, though, what do you think about creating a follow-up ticket to schedule when each will be removed and announce all the removals? I think that we can even fit some of the removals in February (the ones that have codemods or have almost no usage), so we need to announce them as soon as possible and proceed with removals

@augustobmoura augustobmoura merged commit edad967 into master Jan 9, 2024
17 checks passed
@augustobmoura augustobmoura deleted the fx-4483-review-and-create-follow-ups-for-deprecated-parts-of-picasso branch January 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants