-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4483] Add Jira tickets for deprecated functionality #4077
[FX-4483] Add Jira tickets for deprecated functionality #4077
Conversation
|
1e2a2b5
to
f50a6f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it's time we properly schedule and deal with those deprecations 💪
b49e5eb
to
97fe08c
Compare
packages/picasso-rich-text-editor/src/RichTextEditor/RichTextEditor.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great, thank you!
Created ticket are also very detailed and properly described. They miss labels with schedule, though, what do you think about creating a follow-up ticket to schedule when each will be removed and announce all the removals? I think that we can even fit some of the removals in February (the ones that have codemods or have almost no usage), so we need to announce them as soon as possible and proceed with removals
…ditor.tsx Co-authored-by: Aleksandr Shumilov <[email protected]>
FX-4483
Description
Add Jira tickets for deprecated annotations
How to test
Screenshots
No screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?