Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4635] Fix data-private type #4058

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[FX-4635] Fix data-private type #4058

merged 1 commit into from
Dec 12, 2023

Conversation

mkrl
Copy link
Member

@mkrl mkrl commented Dec 12, 2023

FX-4635

Description

There was a mistake in #4056, data-private is boolean, not string

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@mkrl mkrl self-assigned this Dec 12, 2023
@mkrl mkrl requested a review from a team as a code owner December 12, 2023 21:02
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: f89b48c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso Patch
@toptal/picasso-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mkrl mkrl merged commit cdd77e0 into master Dec 12, 2023
10 of 12 checks passed
@mkrl mkrl deleted the fx-4635-fix-type branch December 12, 2023 21:03
@toptal-build toptal-build mentioned this pull request Dec 12, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant