Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4590] Refactor from typescript to plain javascript #4055

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Dec 12, 2023

FX-4590

Description

Refactor Tailwind preset from typescript, so it can be also used in Picasso itself for development.

How to test

Screenshots

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@TomasSlama TomasSlama self-assigned this Dec 12, 2023
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: cee00be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-tailwind Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomasSlama
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-FX-4590-tailwind-preset-f889d3fe5.14+f889d3fe5
yarn add @toptal/[email protected]+f889d3fe5
yarn add @toptal/[email protected]+f889d3fe5
yarn add @toptal/[email protected]+f889d3fe5
yarn add @toptal/[email protected]+f889d3fe5
yarn add @toptal/picasso-pictograms@2.0.1-alpha-FX-4590-tailwind-preset-f889d3fe5.134+f889d3fe5
yarn add @toptal/[email protected]+f889d3fe5
yarn add @toptal/picasso-query-builder@1.2.1-alpha-FX-4590-tailwind-preset-f889d3fe5.2+f889d3fe5
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-FX-4590-tailwind-preset-f889d3fe5.14+f889d3fe5
yarn add @toptal/picasso-shared@13.0.1-alpha-FX-4590-tailwind-preset-f889d3fe5.134+f889d3fe5
yarn add @toptal/picasso-tailwind@1.0.1-alpha-FX-4590-tailwind-preset-f889d3fe5.38+f889d3fe5

@TomasSlama TomasSlama marked this pull request as ready for review December 12, 2023 10:58
@TomasSlama TomasSlama requested a review from a team as a code owner December 12, 2023 10:58
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@TomasSlama TomasSlama merged commit 291c8f8 into master Dec 14, 2023
18 checks passed
@TomasSlama TomasSlama deleted the FX-4590-tailwind-preset branch December 14, 2023 14:05
@toptal-build toptal-build mentioned this pull request Dec 14, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants