Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-2646] Re-add large size for Select #4028

Merged

Conversation

augustobmoura
Copy link
Member

@augustobmoura augustobmoura commented Nov 28, 2023

FX-2646

Description

Re-add large size for Select component

How to test

  • Temploy
  • Check temploy page for Select and Happo screenshots

Screenshots

No screenshots

Development checks

Breaking change

  • [NA] codemod is created and showcased in the changeset
  • [NA] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@augustobmoura augustobmoura requested a review from a team as a code owner November 28, 2023 02:24
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 46c6e12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso Patch
@toptal/picasso-forms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@augustobmoura augustobmoura self-assigned this Nov 28, 2023
@augustobmoura
Copy link
Member Author

@toptal-anvil ping reviewers

@augustobmoura augustobmoura force-pushed the fx-2646-sizes-for-select-endadornment-are-incorrect branch from b7b3899 to cb847c7 Compare November 28, 2023 15:45
@augustobmoura augustobmoura force-pushed the fx-2646-sizes-for-select-endadornment-are-incorrect branch from cb847c7 to 46c6e12 Compare November 28, 2023 16:00
@augustobmoura augustobmoura merged commit a177c79 into master Nov 28, 2023
18 checks passed
@augustobmoura augustobmoura deleted the fx-2646-sizes-for-select-endadornment-are-incorrect branch November 28, 2023 18:36
@toptal-build toptal-build mentioned this pull request Nov 28, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants