-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4505] Add doc on optimizing Picasso for bundle size #4027
[FX-4505] Add doc on optimizing Picasso for bundle size #4027
Conversation
|
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of comments, also I'd suggest to avoid using the gerund so often (Avoiding compound components
> Avoid compound components
), but this is subjective comment and my main argument is that it is a necessary complication (as stated in https://www.jenniferellis.ca/gerunds#:~:text=The%20other%20concern,in%20sentence%20structure.). However, the core of the document contains all information needed, thank you!
@toptal-anvil ping reviewers |
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
.storybook/stories/tutorials/optimizing-for-bundle-size/story/index.tsx
Outdated
Show resolved
Hide resolved
174c339
to
4295e2d
Compare
4295e2d
to
8c3a96e
Compare
FX-4505
Description
Add documentation on optimizing Picasso usage for bundle size
How to test
Screenshots
No screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?