Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4505] Add doc on optimizing Picasso for bundle size #4027

Conversation

augustobmoura
Copy link
Member

@augustobmoura augustobmoura commented Nov 28, 2023

FX-4505

Description

Add documentation on optimizing Picasso usage for bundle size

How to test

  • Temploy
  • Check temploy for new Tutorial

Screenshots

No screenshots

Development checks

Breaking change

  • [NA] codemod is created and showcased in the changeset
  • [NA] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@augustobmoura augustobmoura requested a review from a team as a code owner November 28, 2023 02:00
Copy link

changeset-bot bot commented Nov 28, 2023

⚠️ No Changeset found

Latest commit: 8c3a96e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@augustobmoura augustobmoura self-assigned this Nov 28, 2023
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments, also I'd suggest to avoid using the gerund so often (Avoiding compound components > Avoid compound components), but this is subjective comment and my main argument is that it is a necessary complication (as stated in https://www.jenniferellis.ca/gerunds#:~:text=The%20other%20concern,in%20sentence%20structure.). However, the core of the document contains all information needed, thank you!

@sashuk sashuk requested a review from a team November 28, 2023 10:15
@sashuk
Copy link
Contributor

sashuk commented Nov 28, 2023

@toptal-anvil ping reviewers

@augustobmoura augustobmoura force-pushed the fx-4505-add-guidelines-on-minimising-bundle-size-when-using-picasso-forms branch from 174c339 to 4295e2d Compare November 28, 2023 15:58
@augustobmoura augustobmoura force-pushed the fx-4505-add-guidelines-on-minimising-bundle-size-when-using-picasso-forms branch from 4295e2d to 8c3a96e Compare November 29, 2023 12:49
@augustobmoura augustobmoura merged commit 445e4f5 into master Nov 29, 2023
18 checks passed
@augustobmoura augustobmoura deleted the fx-4505-add-guidelines-on-minimising-bundle-size-when-using-picasso-forms branch November 29, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants