Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4529] Add split button support to Alert #4025

Conversation

mkrl
Copy link
Member

@mkrl mkrl commented Nov 27, 2023

FX-4529

Description

According to BASE, the action buttons in Alert should also support their split variants with dropdown menus.
Each button can either be normal or split, with only two variants available (one of each at the time only).

How to test

  • Temploy
  • See if the code and API looks good
  • Look at the new examples for Alert on the temploy
  • Tests should pass

Screenshots

image

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@mkrl mkrl self-assigned this Nov 27, 2023
@mkrl mkrl requested a review from a team as a code owner November 27, 2023 09:12
Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: ac6bbe9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mkrl
Copy link
Member Author

mkrl commented Nov 27, 2023

@toptal-anvil ping reviewers

@mkrl mkrl requested a review from a team November 27, 2023 12:22
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested on temploy!

@mkrl mkrl merged commit 1709730 into master Nov 27, 2023
8 checks passed
@mkrl mkrl deleted the fx-4529-extend-cta-button-in-the-alert-component-to-use-the-split-button-variant-as-well branch November 27, 2023 12:35
@toptal-build toptal-build mentioned this pull request Nov 27, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants