Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4516] Restore visual tests for Carousel #4017

Merged
merged 34 commits into from
Nov 29, 2023

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Nov 23, 2023

FX-4516

Description

This pull request bumps the version of happo-cypress, that brings fix for Cypress 13 case.

The research was conducted in https://toptal-core.atlassian.net/browse/FX-4516?focusedCommentId=318597 and https://toptal-core.atlassian.net/browse/FX-4516?focusedCommentId=318195, the fix was super quickly added in happo/happo-cypress#109, happo/happo-cypress#110, and happo/happo-e2e#24 by Author of happo-cypress and happo-e2e after problem was reported via email.

How to test

  • Temploy
  • Visuals have to be added for Carousel tests (9 total)
Screenshot 2023-11-29 at 10 46 34

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Nov 23, 2023
Copy link

changeset-bot bot commented Nov 23, 2023

⚠️ No Changeset found

Latest commit: f5e67ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sashuk sashuk force-pushed the fx-4516-return-visual-tests-for-carousel branch 6 times, most recently from d013122 to f6c8e75 Compare November 27, 2023 20:46
@sashuk sashuk changed the title Restore visual tests for Carousel [FX-4516] Restore visual tests for Carousel Nov 28, 2023
@sashuk sashuk force-pushed the fx-4516-return-visual-tests-for-carousel branch 3 times, most recently from b7e9ec2 to 4cb18bb Compare November 29, 2023 09:36
@sashuk sashuk marked this pull request as ready for review November 29, 2023 09:47
@sashuk sashuk requested a review from a team as a code owner November 29, 2023 09:47
@sashuk
Copy link
Contributor Author

sashuk commented Nov 29, 2023

@toptal-anvil ping reviewers

@sashuk sashuk force-pushed the fx-4516-return-visual-tests-for-carousel branch from 4cb18bb to 427f222 Compare November 29, 2023 11:21
@sashuk sashuk marked this pull request as draft November 29, 2023 11:41
@sashuk sashuk force-pushed the fx-4516-return-visual-tests-for-carousel branch from 427f222 to d6e8096 Compare November 29, 2023 14:24
@sashuk sashuk force-pushed the fx-4516-return-visual-tests-for-carousel branch from d6e8096 to f5e67ef Compare November 29, 2023 14:38
@sashuk sashuk marked this pull request as ready for review November 29, 2023 14:48
@sashuk
Copy link
Contributor Author

sashuk commented Nov 29, 2023

@toptal-anvil ping reviewers

Copy link
Member

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to get it so quickly fixed in Happo. Seems to work great, nice job!

@mkrl mkrl requested a review from a team November 29, 2023 15:32
@sashuk sashuk merged commit ff75f54 into master Nov 29, 2023
28 of 29 checks passed
@sashuk sashuk deleted the fx-4516-return-visual-tests-for-carousel branch November 29, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants