-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4516] Restore visual tests for Carousel #4017
Conversation
|
d013122
to
f6c8e75
Compare
b7e9ec2
to
4cb18bb
Compare
@toptal-anvil ping reviewers |
4cb18bb
to
427f222
Compare
427f222
to
d6e8096
Compare
d6e8096
to
f5e67ef
Compare
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to get it so quickly fixed in Happo. Seems to work great, nice job!
FX-4516
Description
This pull request bumps the version of
happo-cypress
, that brings fix for Cypress 13 case.The research was conducted in https://toptal-core.atlassian.net/browse/FX-4516?focusedCommentId=318597 and https://toptal-core.atlassian.net/browse/FX-4516?focusedCommentId=318195, the fix was super quickly added in happo/happo-cypress#109, happo/happo-cypress#110, and happo/happo-e2e#24 by Author of
happo-cypress
andhappo-e2e
after problem was reported via email.How to test
Development checks
props
in component with documentationexamples
for componentPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?