Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4525] Do not use GSM for getting GitHub token #4011

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Nov 21, 2023

FX-4525

Description

This pull request makes workflow that updates dependabot pull request title to use regular GitHub token.

How to test

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Nov 21, 2023
@sashuk sashuk changed the title Do not use GSM for getting GitHub token [FX-4525] Do not use GSM for getting GitHub token Nov 21, 2023
Copy link

changeset-bot bot commented Nov 21, 2023

⚠️ No Changeset found

Latest commit: 59d942a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sashuk sashuk marked this pull request as ready for review November 21, 2023 10:10
@sashuk sashuk requested a review from a team as a code owner November 21, 2023 10:10
@sashuk
Copy link
Contributor Author

sashuk commented Nov 21, 2023

@toptal-anvil ping reviewers

@sashuk sashuk requested a review from a team November 21, 2023 10:17
@sashuk sashuk merged commit a2577c5 into master Nov 21, 2023
18 checks passed
@sashuk sashuk deleted the FX-NULL-fix-token-passing branch November 21, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants