Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picasso-tailwind package.json exports #4008

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

augustobmoura
Copy link
Member

@augustobmoura augustobmoura commented Nov 21, 2023

Description

Describe the changes and motivations for the pull request.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@augustobmoura augustobmoura self-assigned this Nov 21, 2023
@augustobmoura augustobmoura requested a review from a team as a code owner November 21, 2023 03:56
Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 856c2bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-tailwind Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@augustobmoura
Copy link
Member Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@52.0.1-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.70+856c2bcc1
yarn add @toptal/[email protected]+856c2bcc1
yarn add @toptal/picasso-charts@55.1.1-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.32+856c2bcc1
yarn add @toptal/picasso-codemod@5.6.4-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.21+856c2bcc1
yarn add @toptal/picasso-forms@65.0.2-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.41+856c2bcc1
yarn add @toptal/picasso-pictograms@2.0.1-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.91+856c2bcc1
yarn add @toptal/picasso-provider@3.4.2-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.82+856c2bcc1
yarn add @toptal/picasso-query-builder@1.1.3-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.2+856c2bcc1
yarn add @toptal/picasso-rich-text-editor@9.0.2-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.41+856c2bcc1
yarn add @toptal/picasso-shared@13.0.1-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.91+856c2bcc1
yarn add @toptal/picasso-tailwind@0.0.2-alpha-hotfix-picasso-tailwind-exports-856c2bcc1.3936+856c2bcc1

@augustobmoura augustobmoura merged commit 29eeced into master Nov 21, 2023
17 of 21 checks passed
@augustobmoura augustobmoura deleted the hotfix/picasso-tailwind-exports branch November 21, 2023 04:02
@toptal-build toptal-build mentioned this pull request Nov 21, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants