Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4492] Remove unwanted tag transitions #4002

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

mkrl
Copy link
Member

@mkrl mkrl commented Nov 20, 2023

FX-4492

Description

Remove the default transitions from all Tag components.
I was not able to disable them in a single place (in theory, it should be possible to use overrides in PicassoProvider, however, in practice it just didn't work at all, probably due to class overrides inside components).

How to test

  • Temploy
  • You can use the code below to test the transition, both on master and temploy
import React, { useState } from 'react'
import { Button, Container, Tag } from '@toptal/picasso'

const Example = () => {
    const [type, setType] = useState('red')

    return (
        <Container flex>
            <Button
                onClick={() =>
                    setType(prevType => (prevType === 'green' ? 'red' : 'green'))
                }
                size='small'
            >
                Change color
            </Button>
            <Tag.Rectangular variant={type}>Tag</Tag.Rectangular>
        </Container>
    )
}

export default Example

Screenshots

Before

deepin-screen-recorder_Select.area_20231120121350.mp4

After

deepin-screen-recorder_Select.area_20231120121139.mp4

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@mkrl mkrl self-assigned this Nov 20, 2023
Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: c4176d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mkrl mkrl marked this pull request as ready for review November 20, 2023 11:19
@mkrl mkrl requested a review from a team as a code owner November 20, 2023 11:19
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on temploy, looks great!

@sashuk sashuk requested a review from a team November 20, 2023 11:30
@sashuk
Copy link
Contributor

sashuk commented Nov 20, 2023

@toptal-anvil ping reviewers

Co-authored-by: Aleksandr Shumilov <[email protected]>
@mkrl mkrl merged commit 6233bd1 into master Nov 20, 2023
13 checks passed
@mkrl mkrl deleted the fx-4492-tag-components-have-leftover-styles-from-mui branch November 20, 2023 12:11
@toptal-build toptal-build mentioned this pull request Nov 20, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants