Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix alpha packages #3989

Merged
merged 1 commit into from
Nov 16, 2023
Merged

ci: fix alpha packages #3989

merged 1 commit into from
Nov 16, 2023

Conversation

serbantarmure
Copy link
Contributor

@serbantarmure serbantarmure commented Nov 16, 2023

[FX-NNNN]

Description

Describe the changes and motivations for the pull request.

How to test

  • Merge to master
    Breaking change

  • codemod is created and showcased in the changeset

  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@serbantarmure serbantarmure self-assigned this Nov 16, 2023
@serbantarmure serbantarmure requested a review from a team as a code owner November 16, 2023 12:38
Copy link

changeset-bot bot commented Nov 16, 2023

⚠️ No Changeset found

Latest commit: 9629987

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Nov 16, 2023
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @serbantarmure 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@toptal-devbot
Copy link
Collaborator

Fails
🚫

Commit 9629987 does not meet requirements of Commit Message Quality:

  • format of commit title is not correct (read more):

    • Title should start with capital letter
    • Title should not end with a full-stop (i.e .)

    Example of a valid commit title:

    • Regular commit message
    • [FOO-1234] Commit with prefix
    • [FOO][BAR] Coupled prefixes
🚫

The pull request title doesn't conform to Toptal's engineering practices. For guidance on how to fix this problem please refer here

Generated by 🚫 dangerJS against 9629987

@serbantarmure serbantarmure merged commit cd8631d into master Nov 16, 2023
11 of 15 checks passed
@serbantarmure serbantarmure deleted the ci-fix-alpha-packages branch November 16, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY no-jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants