-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow label on FieldWrapper to be ReactNode #3856
fix: allow label on FieldWrapper to be ReactNode #3856
Conversation
🦋 Changeset detectedLatest commit: 09972ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also have a example on Storybook about this new funcionality, wdyt?
Also to have some visual tests for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, tested locally! Having story and visual test as suggested #3856 (review) would be great
@sashuk @augustobmoura, @dmaklygin has discovered that FieldWrapper is the thing that we need to deprecate actually. It is not used any more in Picasso. But still used externally and we do this change for suffering people. Most likely we will delete it soon. So I guess no need to put more efforts into it to cover with tests. Ticket for future investigation of FieldWrapper future: https://toptal-core.atlassian.net/browse/FX-4335 |
75375e9
to
ca2bf33
Compare
@toptal-anvil ping reviewers |
ca2bf33
to
09972ec
Compare
* fix: allow label on FieldWrapper to be ReactNode * fix: add changesets * fix: imrove typing
FX-4318
Description
Users want to be able to do complex things with labels, like for example have in label icon and Tooltip. For this we change label type on FieldWrapper from
string
toReactNode
How to test
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?