Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Picasso): allow overriding jss #3845

Closed
wants to merge 1 commit into from
Closed

Conversation

iatanas0v
Copy link
Contributor

@iatanas0v iatanas0v commented Sep 1, 2023

[FX-NNNN]

Description

Describe the changes and motivations for the pull request.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@iatanas0v iatanas0v self-assigned this Sep 1, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

⚠️ No Changeset found

Latest commit: aa08e8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iatanas0v
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/[email protected]+6dabf5165
yarn add @toptal/[email protected]+6dabf5165
yarn add @toptal/[email protected]+6dabf5165
yarn add @toptal/[email protected]+6dabf5165
yarn add @toptal/[email protected]+6dabf5165
yarn add @toptal/[email protected]+6dabf5165
yarn add @toptal/[email protected]+6dabf5165
yarn add @toptal/picasso-rich-text-editor@6.0.2-alpha-change-styles-root-6dabf5165.1+6dabf5165
yarn add @toptal/[email protected]+6dabf5165

@toptal-devbot toptal-devbot temporarily deployed to staging September 1, 2023 14:51 Inactive
@iatanas0v
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/[email protected]+aa08e8bfe
yarn add @toptal/[email protected]+aa08e8bfe
yarn add @toptal/[email protected]+aa08e8bfe
yarn add @toptal/[email protected]+aa08e8bfe
yarn add @toptal/[email protected]+aa08e8bfe
yarn add @toptal/[email protected]+aa08e8bfe
yarn add @toptal/[email protected]+aa08e8bfe
yarn add @toptal/picasso-rich-text-editor@6.0.2-alpha-change-styles-root-aa08e8bfe.1+aa08e8bfe
yarn add @toptal/[email protected]+aa08e8bfe

@TomasSlama
Copy link
Contributor

Hey @iatanas0v, any update on this PR? Do we need it?

@iatanas0v
Copy link
Contributor Author

Hey @iatanas0v, any update on this PR? Do we need it?

Hey. It was for a proof of concept. I'll close it

@iatanas0v iatanas0v closed this Sep 28, 2023
@iatanas0v iatanas0v deleted the change-styles-root branch September 28, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants