-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add coverage report #3843
Conversation
|
Coverage after merging fx-4208-add-code-coverage-reporting-to-picasso into master will be
Coverage Report for Changed Files
|
6fca326
to
5af9065
Compare
@toptal-anvil ping reviewers |
Co-authored-by: Dmitry Maklygin <[email protected]>
* chore(ci): add coverage report * chore(ci): collect coverage from all packages * chore(ci): fix token * chore(ci): only create local report * chore: reuse ci command Co-authored-by: Dmitry Maklygin <[email protected]> --------- Co-authored-by: Dmitry Maklygin <[email protected]>
FX-4208
Description
Adds Jest coverage reporting command. Coverage can be collected locally by running
yarn test:unit:coverage
, the report will be incoverage/jest
How to test
yarn test:unit:coverage
locally, inspect the reportDevelopment checks
props
in component with documentationexamples
for componentPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?