Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add coverage report #3843

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

mkrl
Copy link
Member

@mkrl mkrl commented Sep 1, 2023

FX-4208

Description

Adds Jest coverage reporting command. Coverage can be collected locally by running yarn test:unit:coverage, the report will be in coverage/jest

How to test

  • Temploy
  • Run yarn test:unit:coverage locally, inspect the report
  • You should also see a top-down report summary in terminal

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@mkrl mkrl requested a review from a team as a code owner September 1, 2023 11:23
@mkrl mkrl self-assigned this Sep 1, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

⚠️ No Changeset found

Latest commit: efc5cf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@toptal-devbot toptal-devbot temporarily deployed to staging September 1, 2023 11:35 Inactive
@toptal-devbot toptal-devbot temporarily deployed to staging September 4, 2023 11:42 Inactive
@toptal-devbot
Copy link
Collaborator

Coverage after merging fx-4208-add-code-coverage-reporting-to-picasso into master will be

62.53%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines

@toptal-devbot toptal-devbot temporarily deployed to staging September 4, 2023 12:01 Inactive
@mkrl mkrl force-pushed the fx-4208-add-code-coverage-reporting-to-picasso branch from 6fca326 to 5af9065 Compare September 4, 2023 15:15
@mkrl mkrl requested a review from a team September 4, 2023 15:15
package.json Outdated Show resolved Hide resolved
@mkrl
Copy link
Member Author

mkrl commented Sep 4, 2023

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to staging September 4, 2023 15:40 Inactive
@mkrl mkrl requested a review from a team September 4, 2023 15:53
Co-authored-by: Dmitry Maklygin <[email protected]>
@toptal-devbot toptal-devbot temporarily deployed to staging September 4, 2023 18:15 Inactive
@mkrl mkrl merged commit cec1e7f into master Sep 4, 2023
18 checks passed
@mkrl mkrl deleted the fx-4208-add-code-coverage-reporting-to-picasso branch September 4, 2023 19:21
sashuk pushed a commit that referenced this pull request Sep 14, 2023
* chore(ci): add coverage report

* chore(ci): collect coverage from all packages

* chore(ci): fix token

* chore(ci): only create local report

* chore: reuse ci command

Co-authored-by: Dmitry Maklygin <[email protected]>

---------

Co-authored-by: Dmitry Maklygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants