Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [FX-4270] align tab sizes in RichText and RichTextEditor #3842

Merged
merged 5 commits into from
Sep 4, 2023
Merged

fix: [FX-4270] align tab sizes in RichText and RichTextEditor #3842

merged 5 commits into from
Sep 4, 2023

Conversation

dmaklygin
Copy link
Contributor

@dmaklygin dmaklygin commented Sep 1, 2023 •
edited
Loading

FX-4270

Description

Tab sizes between RichText and RichTextEditor must be equal (in CodeBlocks).
Right now, tab size in RichText is 8, in RichTextEditor is 1.
They both must be 2.

How to test

  • Check RichText stories on temploy
  • Add code block and try adding several tabs.
  • Compare appearance in RTE and RichText

Screenshots

Picasso | RichText 2023-09-01 17-22-29

Development checks

  • Add changeset according to guidelines (if needed)
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Ensure that deployed demo has expected results and good examples
  • Self reviewed

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@dmaklygin dmaklygin self-assigned this Sep 1, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e472b25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-rich-text-editor Patch
@toptal/picasso-forms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot temporarily deployed to staging September 1, 2023 11:03 Inactive
@dmaklygin dmaklygin changed the title fix: align tab size in RichText fix: [FX-4270] align tab size in RichText Sep 1, 2023
@dmaklygin dmaklygin changed the title fix: [FX-4270] align tab size in RichText fix: [FX-4270] align tab sizes in RichText and RichTextEditor Sep 1, 2023
@dmaklygin dmaklygin marked this pull request as ready for review September 1, 2023 14:23
@dmaklygin dmaklygin requested a review from a team as a code owner September 1, 2023 14:23
@dmaklygin
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to staging September 1, 2023 14:39 Inactive
@toptal-devbot toptal-devbot temporarily deployed to staging September 4, 2023 08:07 Inactive
sashuk
sashuk approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested on temploy

Screenshot 2023-09-04 at 10 35 17

@toptal-devbot toptal-devbot temporarily deployed to staging September 4, 2023 10:37 Inactive
augustobmoura
augustobmoura approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@augustobmoura augustobmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dmaklygin dmaklygin merged commit 8829b26 into master Sep 4, 2023
18 checks passed
@dmaklygin dmaklygin deleted the fx-4270-fix-tabs branch September 4, 2023 14:49
@toptal-build toptal-build mentioned this pull request Sep 4, 2023
Merged
1 task
sashuk pushed a commit that referenced this pull request Sep 14, 2023
@dmaklygin @sashuk
fix: [FX-4270] align tab sizes in RichText and RichTextEditor (#3842)
920213b 
* fix: align tab size in RichText

* fix: set up a proper tab size for RTE

* chore: update changeset

* chore: fix styles

* chore: update changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashuk sashuk sashuk approved these changes

@augustobmoura augustobmoura augustobmoura approved these changes

Assignees

@dmaklygin dmaklygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaklygin @sashuk @augustobmoura @toptal-devbot